[PATCH] D54697: [llvm-objdump] Add `Version References` dumper (PR30241)

[Xing via Phabricator via llvm-commits]

Higuoxing added inline comments.


================
Comment at: tools/llvm-objdump/ELFDump.cpp:187
+
+  const typename ELFO::Elf_Shdr *GNUVerDepSec = nullptr;
+  for (const typename ELFO::Elf_Shdr &Sec : *SectionsOrError) {
----------------
jhenderson wrote:
> You can use `ELFT::Elf_Shdr` here and elsewhere directly, and avoid the need for the `typename`.
> 
> I'm also not sure what "GNUVerDepSec" means, so that probably needs expanding a bit more (especially the "Dep" part).
I change it to `VerNeedSec`


Repository:
  rL LLVM

https://reviews.llvm.org/D54697