[PATCH] D54695: [PM] Port Scalarizer to the new pass manager.
Markus Lavin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 21 01:15:28 PST 2018
markus added a comment.
I do not have a strong opinion about renaming 'transform' to 'visit' and would be happy to comply but simply doing a rename does not compile giving errors such as
../lib/Transforms/Scalar/Scalarizer.cpp:311:25: error: non-const lvalue reference to type 'llvm::Function' cannot bind to a value of unrelated type 'llvm::Instruction *'
bool Done = visit(I);
^
../lib/Transforms/Scalar/Scalarizer.cpp:302:41: note: passing argument to parameter 'F' here
bool ScalarizerVisitor::visit(Function &F) {
^
so it would appear to require some additional changes to make it work.
https://reviews.llvm.org/D54695
More information about the llvm-commits
mailing list