[PATCH] D54779: [Sanitizer] Adding setvbuf in supported platforms and other stream buffer functions

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 20 17:35:28 PST 2018


vitalybuka added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7320
+    COMMON_INTERCEPTOR_WRITE_RANGE(ctx, buf, BUFSIZ);
+    unpoison_file(stream);
+  }
----------------
Please unpoison always
setbuf(null) may change file state




================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_posix.h:1077
+#undef BUFSIZ
+#if SANITIZER_LINUX
+#define BUFSIZ 8192
----------------
do we include file with this def?



Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D54779





More information about the llvm-commits mailing list