[PATCH] D54730: [DomTree] Fix order of domtree updates in MergeBlockIntoPredecessor.

[Brian Rzycki via Phabricator via llvm-commits]

brzycki added a comment.

Has anyone run CTMark test-suite numbers on this patch before and after? @efriedma is it possible to post the extreme C++ case to analyze exactly what's happening in the Dominator update routines and why?



================
Comment at: lib/Transforms/Utils/BasicBlockUtils.cpp:163
   // DTU update: Collect all the edges that exit BB.
   // These dominator edges will be redirected from Pred.
   std::vector<DominatorTree::UpdateType> Updates;
----------------
kuhar wrote:
> I would appreciate a comment explaining that the order of updates matter in this place, in case we want to revisit it some time later.
+1


Repository:
  rL LLVM

https://reviews.llvm.org/D54730