[PATCH] D53461: [X86][compiler-rt] Add additional CPUs and features to the cpu detection to match libgcc

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 20 11:11:21 PST 2018


craig.topper added a comment.

@vitalybuka, the macro in the code specifically checks the value before doing the shift. Is there something wrong with my logic?

#define setFeature(F)              \

  do {                             \
    if (F < 32)                    \
      Features |= 1 << F;          \
    else if (F < 64)               \
      Features2 |= 1 << (F - 32);  \
  } while (0)


Repository:
  rL LLVM

https://reviews.llvm.org/D53461





More information about the llvm-commits mailing list