[PATCH] D54472: Disable invalid isPodLike<> specialization

serge via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 20 07:03:39 PST 2018


serge-sans-paille added a comment.

@chandlerc , @dblaikie

clang implements `is_trivially_copyable` since at least 3.4. gcc implements it since 5.x, and it implements `std::_is_trivial` which is slighlty stronger but ok since 4.X, as illustrated in https://godbolt.org/z/iBDvYp

I'm currently validating a slight update of `llvm::Optional<T>` that's trivially copyable when `T` is, so that point should be okay too.

So I'm going that way, renaming `isPodLike` into `llvm::is_trivially_copyable`, slightly improving the support for older GCC version and that should be all fine.


https://reviews.llvm.org/D54472





More information about the llvm-commits mailing list