[PATCH] D54719: [Intrinsic] Signed Fixed Point Multiplication Intrinsic

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/test/CodeGen/X86/smul_fix.ll:3
+; RUN: llc < %s -mcpu=generic -mtriple=x86_64-linux | FileCheck %s
+; RUN: llc < %s -mcpu=generic -mtriple=i686 -mattr=cmov | FileCheck %s --check-prefix=CHECK32
+
----------------
You should be able to drop -mcpu, also please can you use -check-prefix=X64 and -check-prefix=X86 ?


================
Comment at: llvm/test/CodeGen/X86/smul_fix.ll:9
+declare  <4 x i32> @llvm.smul.fix.v4i32(<4 x i32>, <4 x i32>, i32)
+
+define i32 @func(i32 %x, i32 %y) {
----------------
Add nounwind to all the tests to reduce stack codegen?


Repository:
  rL LLVM

https://reviews.llvm.org/D54719