[PATCH] D54701: Fix DynamicLibraryTests build on Windows when LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is ON

[Michael Platings via Phabricator via llvm-commits]

michaelplatings added a comment.

Thanks for the review Frederich.

> I'm not a fan of writing test stuff into <buildroot>/lib.

I hear you, but for single-configuration builds that's exactly where libDynamicLibraryLib.a is already, along with libgtest.a and libgtest_main.a. This change just makes the Windows build more consistent with builds on Linux etc.

> Is fixing extract_symbols.py to handle whatever is needed a better option?

I don't believe it's a better option, but I could modify extract_symbols.py to additionally look in lib/<config>. I'll go with your decision.


Repository:
  rL LLVM

https://reviews.llvm.org/D54701