[PATCH] D54546: [ARM] Don't expand sdiv when optimising for minsize

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 20 04:58:32 PST 2018


SjoerdMeijer updated this revision to Diff 174747.
SjoerdMeijer retitled this revision from "[DAGCombiner] Don't expand sdiv when optimising for minsize" to "[ARM] Don't expand sdiv when optimising for minsize".
SjoerdMeijer added a comment.

While looking what X86 as doing (and why it was doing the right thing), I noticed that I should just implement `TargetLowering::BuildSDIVPow2`. So that's what I am doing now, and thus it's no longer a DAGCombine change but just an ARM one.
Different tests and targets have been added, and a check for larger constants.


https://reviews.llvm.org/D54546

Files:
  lib/Target/ARM/ARMISelLowering.cpp
  lib/Target/ARM/ARMISelLowering.h
  test/CodeGen/ARM/sdiv-opt-size.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54546.174747.patch
Type: text/x-patch
Size: 5542 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181120/1a349e42/attachment.bin>


More information about the llvm-commits mailing list