[PATCH] D54739: [Sanitizer] intercept setvbuf on other platforms where it is supported

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 20 01:00:04 PST 2018


vitalybuka added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_platform_interceptors.h:519
 #define SANITIZER_INTERCEPT_NETENT SI_NETBSD
-#define SANITIZER_INTERCEPT_SETVBUF SI_NETBSD
+#define SANITIZER_INTERCEPT_SETVBUF (SI_NETBSD || SI_FREEBSD || SI_LINUX || SI_MAC)
 #define SANITIZER_INTERCEPT_GETMNTINFO SI_NETBSD
----------------
we don't want to enable this without testing
so either remove new plaform from here or remove it from Unsupported
Mac and linux is safe to enable. we have bots and should quckly notice issues
I still suspect that unpoisonfile is needed.
  


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D54739





More information about the llvm-commits mailing list