[PATCH] D54734: [WebAssembly] Remove unused function return types (NFC)
Heejin Ahn via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 19 16:41:18 PST 2018
This revision was automatically updated to reflect the committed changes.
Closed by commit rL347277: [WebAssembly] Remove unused function return types (NFC) (authored by aheejin, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D54734
Files:
llvm/trunk/lib/MC/WasmObjectWriter.cpp
Index: llvm/trunk/lib/MC/WasmObjectWriter.cpp
===================================================================
--- llvm/trunk/lib/MC/WasmObjectWriter.cpp
+++ llvm/trunk/lib/MC/WasmObjectWriter.cpp
@@ -324,8 +324,8 @@
uint32_t getRelocationIndexValue(const WasmRelocationEntry &RelEntry);
uint32_t getFunctionType(const MCSymbolWasm &Symbol);
uint32_t getEventType(const MCSymbolWasm &Symbol);
- uint32_t registerFunctionType(const MCSymbolWasm &Symbol);
- uint32_t registerEventType(const MCSymbolWasm &Symbol);
+ void registerFunctionType(const MCSymbolWasm &Symbol);
+ void registerEventType(const MCSymbolWasm &Symbol);
};
} // end anonymous namespace
@@ -1078,7 +1078,7 @@
return TypeIndices[&Symbol];
}
-uint32_t WasmObjectWriter::registerFunctionType(const MCSymbolWasm &Symbol) {
+void WasmObjectWriter::registerFunctionType(const MCSymbolWasm &Symbol) {
assert(Symbol.isFunction());
WasmSignature S;
@@ -1096,10 +1096,9 @@
LLVM_DEBUG(dbgs() << "registerFunctionType: " << Symbol
<< " new:" << Pair.second << "\n");
LLVM_DEBUG(dbgs() << " -> type index: " << Pair.first->second << "\n");
- return Pair.first->second;
}
-uint32_t WasmObjectWriter::registerEventType(const MCSymbolWasm &Symbol) {
+void WasmObjectWriter::registerEventType(const MCSymbolWasm &Symbol) {
assert(Symbol.isEvent());
// TODO Currently we don't generate imported exceptions, but if we do, we
@@ -1118,7 +1117,6 @@
LLVM_DEBUG(dbgs() << "registerEventType: " << Symbol << " new:" << Pair.second
<< "\n");
LLVM_DEBUG(dbgs() << " -> type index: " << Pair.first->second << "\n");
- return Pair.first->second;
}
static bool isInSymtab(const MCSymbolWasm &Sym) {
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54734.174710.patch
Type: text/x-patch
Size: 1745 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181120/41972f0b/attachment.bin>
More information about the llvm-commits
mailing list