[PATCH] D54661: [WebAssembly] Don't override default implementation of isOffsetFoldingLegal. NFC.

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 19 16:36:15 PST 2018


sbc100 added a comment.

In https://reviews.llvm.org/D54661#1303664, @dschuff wrote:

> Not sure I am parsing your commit message right. So we fold if DSO local, and not otherwise?


Actually, even for DSO-local symbols we might not be able to do constant folding since we need to offset all accessed via `get_global __memory_base`.


Repository:
  rL LLVM

https://reviews.llvm.org/D54661





More information about the llvm-commits mailing list