[PATCH] D54689: [WebAssembly] Rename function types to signatures
Derek Schuff via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 19 16:25:37 PST 2018
dschuff added inline comments.
================
Comment at: lib/MC/WasmObjectWriter.cpp:234
- DenseMap<WasmSignature, uint32_t, WasmSignatureDenseMapInfo> SignatureIndices;
+ DenseMap<WasmSignature, uint32_t, WasmSignatureDenseMapInfo>
+ SignatureIndexMap;
----------------
One thing I started trying to do was remove WasmObjectWriter's version of `WasmSignature` (it now has a name that reflects what it is, which is good; but it's basically a duplicate of the one in BinaryFormat, which is bad). It's kind of annoying to find a good place to put it though, which is why I didn't finish.
Repository:
rL LLVM
https://reviews.llvm.org/D54689
More information about the llvm-commits
mailing list