[PATCH] D54581: [compiler-rt] Windows Debug build fix

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: lib/asan/asan_new_delete.cc:76
+  void *res = asan_memalign(0, size, &stack, type);\
+  if (!nothrow && UNLIKELY(!res)) ReportOutOfMemory(size, &stack);\
+  return res;
----------------
mcgov wrote:
> vitalybuka wrote:
> > ALLOCATE_FROM_LOCAL_POOL is used for early allocations when asan is not initialized, so asan_memalign will not work.
> > 
> It looks like ALLOCATE_FROM_LOCAL_POOL is statically defined and only really important on RTEMS, so this wouldn't matter here. The original definition is still below in the #else condition. This section is only for Windows.
> 
> When running the test suite for this though, the debug build will complete with this fix. It will not successfully run the asan-check-dynamic suite though, so I need to figure out what's going wrong there.
sgtm


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D54581