[PATCH] D54548: Add interceptor for the setvbuf(3) from NetBSD

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7274
+  if (buf)
+    COMMON_INTERCEPTOR_WRITE_RANGE(ctx, buf, size);
+  return ret;
----------------
vitalybuka wrote:
> vitalybuka wrote:
> > do you need unpoison_file?
> unpoison_file does nothing on netbsd
> so it could be needed for Linux
FILE is not sanitized as of today on NetBSD.


================
Comment at: lib/sanitizer_common/sanitizer_platform_interceptors.h:519
 #define SANITIZER_INTERCEPT_NETENT SI_NETBSD
+#define SANITIZER_INTERCEPT_SETVBUF SI_NETBSD
 
----------------
vitalybuka wrote:
> This is not NETBSD specific?
It originated in BSD, went into SunOS, and from there to C89 or similar.. but I cannot test it on other OSes. Please enable and test it on them in a separate commit.


Repository:
  rL LLVM

https://reviews.llvm.org/D54548