[PATCH] D54702: Add interceptors for the strtoi(3)/strtou(3) from NetBSD

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:7303
+INTERCEPTOR(INTMAX_T, strtoi, const char *nptr, char **endptr, int base,
+            INTMAX_T low, INTMAX_T high, int *rstatus) {
+  void *ctx;
----------------
krytarowski wrote:
> krytarowski wrote:
> > vitalybuka wrote:
> > > There is INTERCEPTORS_STRTO_BASE in msan
> > > Probably we should try to move them into common, and than add new interceptors.
> > > If this is hard to move, then just add strtoi there
> > Do you mean, to add strtoi for MSan only?
> > 
> > Yes, the interceptors shall be made generic.. however we are not able to do it in this iteration.
> BTW. I will drop you a line in a mail.
not sure what is long term is better
maybe adding this just into msan and later converting to _common would be easier



Repository:
  rL LLVM

https://reviews.llvm.org/D54702