[PATCH] D53736: [BTF] Add BTF DebugInfo

Yonghong Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 19 12:38:48 PST 2018


yonghong-song added a comment.

@MaskRay does this patch addressed your comments?
@dblaikie @echristo I currently included BTFDebug.cpp in build only if BPF is in the target list. This is intended to reduce the final binary size. Another approach is to put BTFDebug.cpp in lib/Target/BPF directory. But that involves exposing several private headers in lib/CodeGen/AsmPrinter directory. if the refactoring is anticipated to involve nontrivial work, maybe we can first use the CMakefile tweaking approach and we can have another patch to deal with refactoring? Please let me know your thought. Thanks!


Repository:
  rL LLVM

https://reviews.llvm.org/D53736





More information about the llvm-commits mailing list