[PATCH] D54683: [WebAssembly] Delete unused using statements (NFC)

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added a comment.

Great, thanks.

I'm not sure how you created this change, but I think using statements are like IWYU in that you don't want remove any line that can be removed and have the file still compile.  i.e. you don't want to rely on recursively included using statements.



================
Comment at: wasm/InputFiles.h:23
 
-using llvm::object::Archive;
 using llvm::object::WasmObjectFile;
----------------
Archive::Symbol does looks like its used below


================
Comment at: wasm/SymbolTable.h:21
-using llvm::wasm::WasmGlobalType;
-using llvm::wasm::WasmSignature;
-
----------------
These do look like they are used.



Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D54683