[llvm] r347241 - [InterleavedLoadCombine] Fix warnings

[Vedant Kumar via llvm-commits]

Hi Martin,

I do still see a build breakage with this applied:

llvm/lib/CodeGen/InterleavedLoadCombinePass.cpp:1037:37: error: invalid operands to binary expression ('llvm::raw_ostream' and '(anonymous namespace)::Polynomial')
      OS << ((i == 0) ? "[" : ", ") << EI[i].Ofs;
      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~

Mind taking a look?

thanks,
vedant

> On Nov 19, 2018, at 1:35 PM, Martin Elshuber via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Author: martin.elshuber
> Date: Mon Nov 19 10:35:31 2018
> New Revision: 347241
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=347241&view=rev
> Log:
> [InterleavedLoadCombine] Fix warnings
> 
> * remove unused function
> * fix compare
> 
> 
> Modified:
>    llvm/trunk/lib/CodeGen/InterleavedLoadCombinePass.cpp
> 
> Modified: llvm/trunk/lib/CodeGen/InterleavedLoadCombinePass.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/InterleavedLoadCombinePass.cpp?rev=347241&r1=347240&r2=347241&view=diff
> ==============================================================================
> --- llvm/trunk/lib/CodeGen/InterleavedLoadCombinePass.cpp (original)
> +++ llvm/trunk/lib/CodeGen/InterleavedLoadCombinePass.cpp Mon Nov 19 10:35:31 2018
> @@ -619,11 +619,6 @@ private:
>   }
> };
> 
> -static raw_ostream &operator<<(raw_ostream &OS, const Polynomial &P) {
> -  P.print(OS);
> -  return OS;
> -}
> -
> /// VectorInfo stores abstract the following information for each vector
> /// element:
> ///
> @@ -810,7 +805,7 @@ public:
>       Result.PV = LHS.PV;
>     }
>     // Both operands produced sensible results?
> -    else if ((LHS.BB == RHS.BB) && (LHS.PV == LHS.PV)) {
> +    else if ((LHS.BB == RHS.BB) && (LHS.PV == RHS.PV)) {
>       Result.BB = LHS.BB;
>       Result.PV = LHS.PV;
>     }
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits