[PATCH] D54651: [ELF] Allow --noinhibit-exec to produce corrupted executable with relocation overflow

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: test/ELF/x86-64-reloc-range.s:4
 // RUN: not ld.lld %t.o -o /dev/null -shared 2>&1 | FileCheck %s
+// RUN: ld.lld --noinhibit-exec -shared %t.o -o %t 2>&1 | FileCheck %s
+// RUN: ls %t
----------------
grimar wrote:
> I think you should change the `\lld\test\ELF\no-inhibit-exec.s` test case instead.
When more than features interact it may be hazy where we should put the test but I do think the check should be put here as it checks that relocation overflow isn't fatal in the case of `--noinhibit-exec`. `--noinhibit-exec` is also used in other tests.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D54651