[PATCH] D52827: [LICM] Make LICM able to hoist phis

[Nick Desaulniers via llvm-commits]

On Mon, Nov 19, 2018 at 9:39 AM John Brawn <John.Brawn at arm.com> wrote:
>
> It's already been reverted in r347225.

Ah, that explains why I can't reproduce after syncing both trees. :)

Thanks for the revert.

>
> John
>
> > -----Original Message-----
> > From: Nick Desaulniers [mailto:ndesaulniers at google.com]
> > Sent: 19 November 2018 17:16
> > To: Maxim Kuvyrkov; John Brawn
> > Cc: reviews+D52827+public+c1a753166f0ac066 at reviews.llvm.org;
> > reviews at reviews.llvm.org; listmail at philipreames.com; hfinkel at anl.gov;
> > max.kazantsev at azul.com; serguei.katkov at azul.com; llvm-
> > commits at lists.llvm.org; jun.l at samsung.com; anna at azul.com; Stephen Hines
> > Subject: Re: [PATCH] D52827: [LICM] Make LICM able to hoist phis
> >
> > On Mon, Nov 19, 2018 at 8:37 AM Maxim Kuvyrkov
> > <maxim.kuvyrkov at linaro.org> wrote:
> > >
> > > Hi John,
> > >
> > > This crashes on AArch64 kernel build:
> > >
> > > https://ci.linaro.org/job/tcwg_kernel-bisect-llvm-master-aarch64-
> > stable-allnoconfig/4/artifact/artifacts/build-
> > d9902c5262f22d97eda691f00daee1ef7f5623b8/3-
> > count_linux_objs/console.log/*view*/
> > >
> > > Let me know if you need help reproducing this.
> > >
> > > --
> > > Maxim Kuvyrkov
> > > www.linaro.org
> >
> > Hi John,
> > Can you please stage a revert for this change? I'll try to get a pared
> > down reproducer.
> >
> > Maxim,
> > Thanks for highlighting this issue, looks like kernelCI is racking up
> > good finds!
> >
> > >
> > >
> > >
> > > > On Nov 19, 2018, at 2:34 PM, John Brawn via Phabricator via llvm-
> > commits <llvm-commits at lists.llvm.org> wrote:
> > > >
> > > > This revision was automatically updated to reflect the committed
> > changes.
> > > > Closed by commit rL347190: [LICM] Make LICM able to hoist phis
> > (authored by john.brawn, committed by ).
> > > >
> > > > Changed prior to commit:
> > > >  https://reviews.llvm.org/D52827?vs=174028&id=174582#toc
> > > >
> > > > Repository:
> > > >  rL LLVM
> > > >
> > > > https://reviews.llvm.org/D52827
> > > >
> > > > Files:
> > > >  llvm/trunk/lib/Transforms/Scalar/LICM.cpp
> > > >  llvm/trunk/test/Transforms/LICM/hoist-phi.ll
> > > >  llvm/trunk/test/Transforms/LoopVectorize/invariant-store-
> > vectorization.ll
> > > >
> > > > <D52827.174582.patch>_______________________________________________
> > > > llvm-commits mailing list
> > > > llvm-commits at lists.llvm.org
> > > > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> > >
> >
> >
> > --
> > Thanks,
> > ~Nick Desaulniers
> IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.



-- 
Thanks,
~Nick Desaulniers