[PATCH] D54697: [llvm-objdump] Add `Version References` dumper (PR30241)

Xing via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 19 07:00:06 PST 2018


Higuoxing added inline comments.


================
Comment at: tools/llvm-objdump/ELFDump.cpp:239-259
 void llvm::printELFDynamicSection(const object::ObjectFile *Obj) {
   if (const auto *ELFObj = dyn_cast<ELF32LEObjectFile>(Obj))
     printDynamicSection(ELFObj->getELFFile(), Obj->getFileName());
   else if (const auto *ELFObj = dyn_cast<ELF32BEObjectFile>(Obj))
     printDynamicSection(ELFObj->getELFFile(), Obj->getFileName());
   else if (const auto *ELFObj = dyn_cast<ELF64LEObjectFile>(Obj))
     printDynamicSection(ELFObj->getELFFile(), Obj->getFileName());
----------------
Seems that these codes are redundant, can we simplify this?


Repository:
  rL LLVM

https://reviews.llvm.org/D54697





More information about the llvm-commits mailing list