[PATCH] D54695: [PM] Port Scalarizer to the new pass manager.

[Fedor Sergeev via Phabricator via llvm-commits]

fedor.sergeev added a comment.

To me it would be a cleaner solution if you could split legacy FunctionPass interface implementation into a separate wrapper pass (e.g. ScalarizerLegacyPass),
similar to how new-pm wrapper ScalarizerPass implements all the new-pm interfaces.
That would allow to separate actual transformation (Scalarizer) from pass-manager details (ScalarizerPass/ScalarizerLegacyPass).

Say, you would not need to perform legacy initializeScalarizerPass when initializing Scalarizer object for new-pm operations.



================
Comment at: lib/Transforms/Scalar/Scalarizer.cpp:159
                    public InstVisitor<Scalarizer, bool> {
+  friend class llvm::ScalarizerPass;
 public:
----------------
Can this friend declaration be removed?


Repository:
  rL LLVM

https://reviews.llvm.org/D54695