[PATCH] D54646: DAG combiner: fold (select, C, X, undef) -> X

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added a comment.

In https://reviews.llvm.org/D54646#1301582, @rampitec wrote:

> In https://reviews.llvm.org/D54646#1301556, @arsenm wrote:
>
> > This pretty much reproduces https://reviews.llvm.org/D48376, but you should copy the test I added
>
>
> The test you have added there does not work anymore.
>  What's the new syntax for @llvm.amdgcn.image.sample.f32.v2f32.v8i32? Is it relevant to use image sample in this test at all?


I think it's because it avoids the fact that regular loads are converted to integer loads, and it was to ensure it was an FP type. You should be able to just copy any other FP returning intrinsic use from another test


https://reviews.llvm.org/D54646