[PATCH] D54669: [ProfileSummary] Standardize methods and fix comment.

[Rodrigo Caetano Rocha via Phabricator via llvm-commits]

rcorcs created this revision.
rcorcs added reviewers: davidxl, eraman.
Herald added a subscriber: llvm-commits.

Every Analysis pass has a get method that returns a reference of the Result of the Analysis,
for example, BlockFrequencyInfo &BlockFrequencyInfoWrapperPass::getBFI().
I believe that ProfileSummaryInfo::getPSI() is the only exception to that, as it was returning a pointer.

Another change is renaming isHotBB and isColdBB to isHotBlock and isColdBlock, respectively.
Most methods use BB as the argument of variable names while methods usually refer to Basic Blocks as Blocks, instead of BB.
For example, Function::getEntryBlock, Loop:getExitBlock, etc.

I also fixed one of the comments.


Repository:
  rL LLVM

https://reviews.llvm.org/D54669

Files:
  include/llvm/Analysis/ProfileSummaryInfo.h
  lib/Analysis/ModuleSummaryAnalysis.cpp
  lib/Analysis/ProfileSummaryInfo.cpp
  lib/CodeGen/CodeGenPrepare.cpp
  lib/Transforms/IPO/HotColdSplitting.cpp
  lib/Transforms/IPO/Inliner.cpp
  lib/Transforms/IPO/PartialInlining.cpp
  lib/Transforms/IPO/SampleProfile.cpp
  lib/Transforms/Instrumentation/ControlHeightReduction.cpp
  lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
  unittests/Analysis/ProfileSummaryInfoTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54669.174515.patch
Type: text/x-patch
Size: 10326 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181117/724357c2/attachment.bin>