[PATCH] D54660: [WebAssembly] Add null streamer support

[Eugene Sharygin via Phabricator via llvm-commits]

eush added a comment.

Thank you! I think this is a better way to support MCNullStreamer than https://reviews.llvm.org/D54614.



================
Comment at: lib/Target/WebAssembly/MCTargetDesc/WebAssemblyTargetStreamer.h:97
+
+  virtual void emitParam(MCSymbol *Symbol, ArrayRef<MVT> Types) override {}
+  virtual void emitResult(MCSymbol *Symbol, ArrayRef<MVT> Types) override {}
----------------
What is `virtual` here for? It seems to be redundant since these functions are already declared virtual in the base class (hence the `override`).


================
Comment at: test/CodeGen/WebAssembly/null-streamer.ll:12
+  call void @llvm.wasm.throw(i32 0, i8* %p) ; This is to generate '.eventtype'
+  call void @g()
+  ret i32 0
----------------
Should there be a similar comment about `.functype` to explain `g`?


Repository:
  rL LLVM

https://reviews.llvm.org/D54660