[PATCH] D54647: WIP: [WebAssembly] First pass the implement -fPIC

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:94
         addSignature(std::move(Signature));
+        //assert(false);
       }
----------------
Delete this?


================
Comment at: lib/Target/WebAssembly/WebAssemblyAsmPrinter.cpp:109
+    auto* Sym = cast<MCSymbolWasm>(It.getValue());
+    //dbgs() << "sym: " << *Sym << "\n";
+    if (Sym->isVariable())
----------------
Delete this too?


================
Comment at: lib/Target/WebAssembly/WebAssemblyFastISel.cpp:799
+    dbgs() << *Func << "\n";
+    dbgs() << "YYY\n";
+    IsDirect = false;
----------------
Delete?


================
Comment at: lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:736
+  //if (isPositionIndependent() )
+    //Opcode = Ins.empty() ? WebAssemblyISD::CALL_INDIRECT1 : WebAssemblyISD::CALL_INDIRECT1;
+  SDValue Res = DAG.getNode(Opcode, DL, InTyList, Ops);
----------------
Delete?


Repository:
  rL LLVM

https://reviews.llvm.org/D54647