[PATCH] D54652: [WebAssembly] replaced .param/.result by .functype

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 16 14:56:50 PST 2018


sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.

Nice!  I wish we could do with without the lexer change and with a more asm-linux syntax.. but I guess that time for bikeshedding that is over.



================
Comment at: lib/MC/MCParser/AsmLexer.cpp:653
+    }
+    return AsmToken(AsmToken::Minus, StringRef(TokStart, 1));
   case '|':
----------------
Is there a risk we could break other asm backends with this?


Repository:
  rL LLVM

https://reviews.llvm.org/D54652





More information about the llvm-commits mailing list