[PATCH] D54540: [ADT] Drop llvm::Optional clang-specific optmization for trivially copyable types

John McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 16 10:34:59 PST 2018


rjmccall added a comment.

Hmm.  This makes `Optional<int>` non-trivial, which is a serious semantic problem for certain uses of the type (e.g. putting it in a union); it's not just an optimization.  Obviously those were unportable because of the `#if`, but we should really fix this.  There's no way that GCC just generically miscompiles all partial specializations.


Repository:
  rL LLVM

https://reviews.llvm.org/D54540





More information about the llvm-commits mailing list