[PATCH] D53794: [TargetLowering] expandFP_TO_UINT - avoid FPE due to out of range conversion (PR17686)

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon updated this revision to Diff 174375.
RKSimon added a comment.

Added early-out for the case where the integer dst type is larger than the float src type maximum value - we should be able to just use FP_TO_SINT. Thanks to @efriedma for noticing that - it affects a MIPS test.

@atanasyan - should the f16 test should be using a smaller type than the i32 so the full uitofp half path is tested?


Repository:
  rL LLVM

https://reviews.llvm.org/D53794

Files:
  include/llvm/CodeGen/TargetLowering.h
  lib/CodeGen/SelectionDAG/TargetLowering.cpp
  lib/Target/X86/X86ISelLowering.cpp
  lib/Target/X86/X86ISelLowering.h
  test/CodeGen/Mips/msa/f16-llvm-ir.ll
  test/CodeGen/X86/fp-cvt.ll
  test/CodeGen/X86/scalar-fp-to-i64.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53794.174375.patch
Type: text/x-patch
Size: 30241 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181116/ff30a91e/attachment-0001.bin>