[PATCH] D54606: [AMDGPU] Convert insert_vector_elt into set of selects

[Nicolai Hähnle via Phabricator via llvm-commits]

nhaehnle added a comment.

Mostly looks good to me.

However, why does code with undef vectors look so bad? For example, in `float4_inselt`, the fact that the initial vector is undef should allow us to just store a splat of 1.0.



================
Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:8118-8119
 
+SDValue SITargetLowering::performInsertVectorEltCombine(
+  SDNode *N, DAGCombinerInfo &DCI) const {
+  SDValue Vec = N->getOperand(0);
----------------
clang-format?


https://reviews.llvm.org/D54606