[llvm] r347054 - [X86][SSE] Move number of input limit out of resolveTargetShuffleInputs.

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 16 07:01:06 PST 2018


Author: rksimon
Date: Fri Nov 16 07:01:05 2018
New Revision: 347054

URL: http://llvm.org/viewvc/llvm-project?rev=347054&view=rev
Log:
[X86][SSE] Move number of input limit out of resolveTargetShuffleInputs. 

Only combineX86ShufflesRecursively needs this limit.

Modified:
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=347054&r1=347053&r2=347054&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Fri Nov 16 07:01:05 2018
@@ -6627,8 +6627,7 @@ static bool resolveTargetShuffleInputs(S
       return false;
 
   resolveTargetShuffleInputsAndMask(Inputs, Mask);
-  // TODO - Add support for more than 2 inputs.
-  return Inputs.size() <= 2;
+  return true;
 }
 
 /// Returns the scalar element that will make up the ith
@@ -31005,7 +31004,10 @@ static SDValue combineX86ShufflesRecursi
   if (!resolveTargetShuffleInputs(Op, OpInputs, OpMask, DAG))
     return SDValue();
 
-  assert(OpInputs.size() <= 2 && "Too many shuffle inputs");
+  // TODO - Add support for more than 2 inputs.
+  if (2 < OpInputs.size())
+    return SDValue();
+
   SDValue Input0 = (OpInputs.size() > 0 ? OpInputs[0] : SDValue());
   SDValue Input1 = (OpInputs.size() > 1 ? OpInputs[1] : SDValue());
 




More information about the llvm-commits mailing list