[PATCH] D54624: [LLD][ELF] Error if _GLOBAL_OFFSET_TABLE_ is defined in input objects

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/Writer.cpp:222
+      Out::ElfHeader, Target->GotBaseSymOff, STV_HIDDEN, STB_GLOBAL,
+      /*AllowMulDef*/ false);
 
----------------
grimar wrote:
> Maybe just inline the code here?
> 
> ```
>   StringRef GotTableSymName =
>       (Config->EMachine == EM_PPC64) ? ".TOC." : "_GLOBAL_OFFSET_TABLE_";
>   if (Symtab->find(GotTableSymName))
>     ElfSym::GlobalOffsetTable = cast<Defined>(
>         Symtab->addDefined(GotTableSymName, Out::ElfHeader,
>                            Target->GotBaseSymOff, STV_HIDDEN, STB_GLOBAL));
> ```
I think we can avoid doing `cast<Defined>` too. Posted D54627 for that.


https://reviews.llvm.org/D54624