[PATCH] D54620: [MSP430] Use R_MSP430_16_BYTE type for FK_Data_2 fixup
Kristina Bessonova via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Nov 16 02:18:11 PST 2018
krisb created this revision.
krisb added a reviewer: asl.
Herald added a subscriber: llvm-commits.
Linker fails to link example like this (simplified case from newlib
sources):
$ cat test.c
extern const char _ctype_b[];
struct _t { char *ptr; };
struct _t T = { ((char *) _ctype_b + 3) };
$ cat ctype.c
char _ctype_b[4] = { 0, 0, 0, 0 };
LD: test.o:(.data+0x0): warning: internal error: unsupported relocation error
We also follow gnu toolchain here, where 2-byte relocation mapped to
R_MSP430_16_BYTE, instead of R_MSP430_16.
Repository:
rL LLVM
https://reviews.llvm.org/D54620
Files:
lib/Target/MSP430/MCTargetDesc/MSP430ELFObjectWriter.cpp
test/MC/MSP430/reloc.s
Index: test/MC/MSP430/reloc.s
===================================================================
--- test/MC/MSP430/reloc.s
+++ test/MC/MSP430/reloc.s
@@ -20,3 +20,8 @@
jmp foo
; CHECK: jmp foo ; encoding: [A,0b001111AA]
; CHECK: ; fixup A - offset: 0, value: foo, kind: fixup_10_pcrel
+
+; RUN: llvm-mc -filetype=obj -triple msp430 < %s | llvm-readobj -r \
+; RUN: | FileCheck -check-prefix=RELOC %s
+.short _ctype+3
+; RELOC: R_MSP430_16_BYTE _ctype 0x3
Index: lib/Target/MSP430/MCTargetDesc/MSP430ELFObjectWriter.cpp
===================================================================
--- lib/Target/MSP430/MCTargetDesc/MSP430ELFObjectWriter.cpp
+++ lib/Target/MSP430/MCTargetDesc/MSP430ELFObjectWriter.cpp
@@ -34,7 +34,7 @@
// Translate fixup kind to ELF relocation type.
switch ((unsigned)Fixup.getKind()) {
case FK_Data_1: return ELF::R_MSP430_8;
- case FK_Data_2: return ELF::R_MSP430_16;
+ case FK_Data_2: return ELF::R_MSP430_16_BYTE;
case FK_Data_4: return ELF::R_MSP430_32;
case MSP430::fixup_32: return ELF::R_MSP430_32;
case MSP430::fixup_10_pcrel: return ELF::R_MSP430_10_PCREL;
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54620.174343.patch
Type: text/x-patch
Size: 1276 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181116/2a136502/attachment.bin>
More information about the llvm-commits
mailing list