[PATCH] D53890: [LTO] Record LTOUnit flag in index and validate during LTO link

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 15 21:34:01 PST 2018


tejohnson updated this revision to Diff 174328.
tejohnson added a comment.

- Switch to an EnableSplitLTOUnit flag.
- Record the value of !EnableSplitLTOUnit in the bitcode for compatibility with current code that has splitting enabled by default
- As discussed off-patch, will use a new, separate option to control this

splitting, here I am using -f[no]split-lto-unit.

- I'll update the patch title and summary once we converge on flag/behavior.


Repository:
  rL LLVM

https://reviews.llvm.org/D53890

Files:
  include/llvm/Analysis/ModuleSummaryAnalysis.h
  include/llvm/Bitcode/BitcodeReader.h
  include/llvm/Bitcode/BitcodeWriterPass.h
  include/llvm/IR/ModuleSummaryIndex.h
  include/llvm/LTO/LTO.h
  include/llvm/Transforms/IPO.h
  include/llvm/Transforms/IPO/ThinLTOBitcodeWriter.h
  lib/Analysis/ModuleSummaryAnalysis.cpp
  lib/Bitcode/Reader/BitcodeReader.cpp
  lib/Bitcode/Writer/BitcodeWriter.cpp
  lib/Bitcode/Writer/BitcodeWriterPass.cpp
  lib/LTO/LTO.cpp
  lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp
  test/Bitcode/thinlto-alias.ll
  test/Bitcode/thinlto-alias2.ll
  test/Bitcode/thinlto-function-summary-callgraph-cast.ll
  test/Bitcode/thinlto-function-summary-callgraph-pgo.ll
  test/Bitcode/thinlto-function-summary-callgraph-profile-summary.ll
  test/Bitcode/thinlto-function-summary-callgraph-relbf.ll
  test/Bitcode/thinlto-function-summary-callgraph-sample-profile-summary.ll
  test/Bitcode/thinlto-function-summary-callgraph.ll
  test/Bitcode/thinlto-function-summary.ll
  test/LTO/Resolution/X86/lto-unit-check.ll
  tools/opt/NewPMDriver.cpp
  tools/opt/opt.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D53890.174328.patch
Type: text/x-patch
Size: 30503 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181116/626284d0/attachment.bin>


More information about the llvm-commits mailing list