[PATCH] D54612: [compiler-rt] Use exact spelling when building for default target

Roland McGrath via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 15 20:04:06 PST 2018


mcgrathr accepted this revision.
mcgrathr added a comment.
This revision is now accepted and ready to land.

lgtm with a comment in the code



================
Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:340
   string(SUBSTRING ${COMPILER_RT_DEFAULT_TARGET_TRIPLE} ${dash_index} -1 triple_suffix)
-  if(ANDROID AND ${arch} STREQUAL "i386")
+  if(COMPILER_RT_DEFAULT_TARGET_ONLY)
+    set(target "${COMPILER_RT_DEFAULT_TARGET_TRIPLE}")
----------------
merits a comment


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D54612





More information about the llvm-commits mailing list