[PATCH] D54605: [lld][ELF] Use SmallDenseSet::count instead of lots of logical "or" operators and add test coverage for "-z" flags.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Thank you for the patch. But honestly I wouldn't do this personally because the former code only depends on the usual equality check while the new code uses `SmallDenseSet` which is undeniably (slightly) more complicated than the comparison. From the perspective of code readability, I don't think there's too much difference, it's perhaps a matter of taste. So I think I prefer code that is simple, which is perhaps too simple that it sometimes even looks a bit stupid.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D54605