[PATCH] D54581: [compiler-rt] Windows Debug build fix

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: lib/asan/asan_new_delete.cc:73
+#ifdef SANITIZER_WINDOWS && DEBUG
+ #define MemalignFromLocalPool(x,y) nullptr
+#endif
----------------
zturner wrote:
> I don't have an opinion on whether this fix is ok, but is the `#ifdef` correct here?  Shouldn't it be `#if defined(SANITIZER_WINDOWS) && defined(DEBUG)` or `#if SANITIZER_WINDOWS && DEBUG`
Looks like we check windoes as #if SANITIZER_WINDOWS and debug as #ifdef DEBUG
so I believe it should be 
#if SANITIZER_WINDOWS && defined(DEBUG)


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D54581