[PATCH] D54543: [stack-safety] Inter-Procedural Analysis implementation

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 15 14:09:05 PST 2018


vitalybuka added a comment.

In https://reviews.llvm.org/D54543#1300349, @vlad.tsyrklevich wrote:

> In https://reviews.llvm.org/D54543#1300326, @vitalybuka wrote:
>
> > That's unfortunate, as now we can keep checks for local and global passes mostly the same and highlight the difference with branched LOCAL-NEXT/GLOBAL-NEXT
>
>
> That's a good point, I didn't consider that it would break that pattern. Though looking at the tests now it seems that the current tests don't have cases where this would happen? Presumably most tests where an alloca has a use in a function call it would result in a local/global difference due to the IPA being able to refine the use range.


Can we reconsider this later. I've added TODO. Probably these are implementation details which are unneeded.


Repository:
  rL LLVM

https://reviews.llvm.org/D54543





More information about the llvm-commits mailing list