[PATCH] D54597: [DebugInfo] DISubprogram flags get their own flags word. NFC
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 15 13:16:31 PST 2018
aprantl added inline comments.
================
Comment at: llvm/include/llvm/IR/DebugInfoSPFlags.def:19
+
+HANDLE_DISP_FLAG(0, Zero) // Use it as zero value.
+ // For example: void foo(DISPFlags Flags = SPFlagZero).
----------------
dblaikie wrote:
> aprantl wrote:
> > That C++-style comment on the same line as the macro looks dangerous :-)
> Any particular danger you've got in mind that wouldn't come up with a comment on a separate line?
You're right, this is a macro expansion, not a definition, so regardless of how the user defines the macro the comment probably won't hurt.
Repository:
rL LLVM
https://reviews.llvm.org/D54597
More information about the llvm-commits
mailing list