[PATCH] D48179: [AMDGPU] Emit MessagePack HSA Metadata for v3 code object

Scott Linder via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 15 12:51:47 PST 2018


scott.linder added a comment.

In https://reviews.llvm.org/D48179#1300366, @kzhuravl wrote:

> what is the rationale for putting the metadata verifier in binary format instead of support?


It is a layering issue; BinaryFormat depends on Support, and the low-level MsgPack implementation is defined in BinaryFormat, so nothing that depends on it can live in Support.


https://reviews.llvm.org/D48179





More information about the llvm-commits mailing list