[PATCH] D54597: [DebugInfo] DISubprogram flags get their own flags word. NFC

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 15 12:25:38 PST 2018


probinson created this revision.
probinson added reviewers: dblaikie, aprantl.
probinson added a project: debug-info.
Herald added subscribers: llvm-commits, JDevlieghere, hiraditya.

Take existing bitfields in DISubprogram and formalize them
into a flags word analogous to DINode::DIFlags, except these
flags are all specific to subprograms.

This patch does NOT change bitcode or IR formats; that will
be in a follow-up (this one is big enough already).

My goal is to have a better place to add new subprogram-specific 
flags such as the ones in https://reviews.llvm.org/D54043.  We could also consider moving
some subprogram-specific flags from DIFlags to DISPFlags.

Note that I have NOT YET run clang-format, as I think the diff is
easier to read in its current state.  i will definitely run it before
committing.


Repository:
  rL LLVM

https://reviews.llvm.org/D54597

Files:
  clang/lib/CodeGen/CGDebugInfo.cpp
  llvm/include/llvm/IR/DIBuilder.h
  llvm/include/llvm/IR/DebugInfoMetadata.h
  llvm/include/llvm/IR/DebugInfoSPFlags.def
  llvm/lib/AsmParser/LLParser.cpp
  llvm/lib/Bitcode/Reader/MetadataLoader.cpp
  llvm/lib/CodeGen/MachineOutliner.cpp
  llvm/lib/IR/DIBuilder.cpp
  llvm/lib/IR/DebugInfo.cpp
  llvm/lib/IR/DebugInfoMetadata.cpp
  llvm/lib/IR/LLVMContextImpl.h
  llvm/tools/opt/Debugify.cpp
  llvm/unittests/CodeGen/MachineInstrTest.cpp
  llvm/unittests/IR/IRBuilderTest.cpp
  llvm/unittests/IR/MetadataTest.cpp
  llvm/unittests/IR/VerifierTest.cpp
  llvm/unittests/Transforms/Utils/CloningTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54597.174268.patch
Type: text/x-patch
Size: 60075 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181115/6e48d181/attachment.bin>


More information about the llvm-commits mailing list