[PATCH] D54543: [stack-safety] Inter-Procedural Analysis implementation

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

In https://reviews.llvm.org/D54543#1299824, @vlad.tsyrklevich wrote:

> The local tests that check for use 'empty-set, $CALL_INFO' for the local and 'full-set, $CALL_INFO' for the global analysis is sort of confusing. It seems like the use is safe in local analysis (empty-set means no uses!) but unsafe in the global, when really the situation is actually local analysis has 'no local uses but used in function calls' and the global analysis is just 'it's safe/unsafe (function call info is integrated into the previous distintion)'. Maybe we should clear all of the UseInfo::Calls fields at the end of StackSafetyDataFlowAnalysis?


That's unfortunate, as now we can keep checks for local and global passes mostly the same and highlight the difference with branched LOCAL-NEXT/GLOBAL-NEXT


Repository:
  rL LLVM

https://reviews.llvm.org/D54543