[PATCH] D54521: tsan: Add pthread_tryjoin_np and pthread_timedjoin_np interceptors
Dmitry Vyukov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 15 09:39:56 PST 2018
dvyukov added a comment.
We need tests for these functions in compiler-rt/test/tsan/
================
Comment at: lib/tsan/rtl/tsan_interceptors.cc:1054
+ ThreadIgnoreEnd(thr, pc);
+ if (res == 0) {
+ ThreadJoin(thr, pc, tid);
----------------
Please remove {}
tsan codebase does not use {} around single-statement if/for.
================
Comment at: lib/tsan/rtl/tsan_interceptors.cc:1066
+ ThreadIgnoreEnd(thr, pc);
+ if (res == 0) {
+ ThreadJoin(thr, pc, tid);
----------------
Please remove {}
tsan codebase does not use {} around single-statement if/for.
Repository:
rCRT Compiler Runtime
https://reviews.llvm.org/D54521
More information about the llvm-commits
mailing list