[PATCH] D54502: [stack-safety] Empty local passes for Stack Safety Local Analysis

[Vlad Tsyrklevich via Phabricator via llvm-commits]

vlad.tsyrklevich added inline comments.


================
Comment at: llvm/include/llvm/Analysis/StackSafetyAnalysis.h:1
+//===- StackSafetyAnalysis.h - Module summary index builder ---*- C++ -*-===//
+//
----------------
Outdated comment.


================
Comment at: llvm/include/llvm/Analysis/StackSafetyAnalysis.h:27
+
+/// Function-local stack safety analysis pass.
+class StackSafetyAnalysis : public AnalysisInfoMixin<StackSafetyAnalysis> {
----------------
I'd prefer if this were 'StackSafetyInfo wrapper for the new pass manager.' and then the upcoming comment on StackSafetyInfo makes it clear what that does. This makes the relationship between StackSafetyAnalysis and StackSafetyInfoWrapperPass clearer.


================
Comment at: llvm/lib/Analysis/StackSafetyAnalysis.cpp:2
+//===- StackSafetyAnalysis.cpp - Safe Stack Insertion
+//-------------------------------===//
+//
----------------
Broken comment formatting


Repository:
  rL LLVM

https://reviews.llvm.org/D54502