[PATCH] D54469: Introduce new `disable_init` ASan option that is only supported on platforms where `SANITIZER_SUPPORTS_DISABLED_INIT` is true. Currently this is only supported on Darwin.

[Dan Liew via Phabricator via llvm-commits]

delcypher marked 2 inline comments as done.
delcypher added inline comments.


================
Comment at: lib/asan/asan_internal.h:114
 
-// Add convenient macro for interface functions that may be represented as
-// weak hooks.
+#if SANITIZER_SUPPORTS_INIT_FOR_DLOPEN
+bool InitIsViaDlopen();
----------------
delcypher wrote:
> kcc wrote:
> > please avoid introducing new ifdefs. There are plenty of them already, but no reason to make things worse. 
> Okay. I will try to just declare these functions without the macro guards and just put stub implementations in each of the platform specific files.
@kcc I've tried to remove the `#ifdef` by always declaring the new functions and implementing each of them for each of the ASan supported platforms.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D54469