[PATCH] D54555: [clang][slh] add attribute for speculative load hardening

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a reviewer: kristof.beyls.
chandlerc added a comment.

Really cool, and nice job with the first round of things. Very nice testing!

Adding Kristof as he and I talked about this general direction and I want him to see the initial patch.

Some questions in-line.



================
Comment at: clang/include/clang/Basic/Attr.td:3092
+  let Spellings = [GNU<"speculative_load_hardening">,
+                   CXX11<"", "speculative_load_hardening", 201811>];
+  let Subjects = SubjectList<[Function], ErrorDiag>;
----------------
Should this be done with `Clang<"speculative_load_hardening">`? Unsure...


================
Comment at: clang/test/CodeGen/attr-speculative-load-hardening.cpp:1-2
+// RUN: %clang_cc1 -std=c++11 -disable-llvm-passes -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK1
+// RUN: %clang_cc1 -std=c++11 -disable-llvm-passes -emit-llvm %s -o - | FileCheck %s --check-prefix=CHECK2
+//
----------------
A question I have is how this interacts with the commandline flag?

Or are you thinking to handle that separately in a follow-up patch?

I'm pretty happy with either approach, mostly curious.


Repository:
  rL LLVM

https://reviews.llvm.org/D54555