[PATCH] D54558: [WebAssembly] Import the stack pointer when building shared libraries

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: wasm/Driver.cpp:346
+createUndefinedGlobal(StringRef Name, llvm::wasm::WasmGlobalType *Type) {
+  auto *Result =
+      cast<UndefinedGlobal>(Symtab->addUndefinedGlobal(Name, 0, nullptr, Type));
----------------
By convention, I think we name this `Sym` rather than `Result`.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D54558