[PATCH] D53444: Support ARM_V4BX relocation

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: test/ELF/v4bx.yaml:2
+# REQUIRES: arm
+# RUN: yaml2obj %s -o %tv4bx.o
+# RUN: ld.lld %tv4bx.o -o %t.out
----------------
nit: since now you have only one object file, %tv4x.o -> %t.o.


================
Comment at: test/ELF/v4bx.yaml:4-6
+# RUN: llvm-readelf -sections %t.out | FileCheck %s
+
+# CHECK: .text
----------------
Does this really check anything? My understanding is that if `ld.lld` succeeds, then the test succeeded. So you don't really need readelf, no?


https://reviews.llvm.org/D53444