[PATCH] D54551: RegisterCoalescer: Assume CR_Replace for SubRangeJoin

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 14 15:40:33 PST 2018


arsenm created this revision.
arsenm added reviewers: MatzeB, kparzysz, qcolombet.
Herald added subscribers: tpr, nhaehnle, wdng, jvesely.

Currently it's possible for following
check on V.WriteLanes (which is not really meaningful
during SubRangeJoin) to pass for one half of the pair,
and then fall through to to one of the impossible
or unresolved states. This then fails as inconsistent
on the other half.

      

During the main range join, the check between V.WriteLanes
and OtherV.ValidLanes must have passed, meaning this
should be a CR_Replace.

      

Fixes most of the testcases in bugs 39542 and 39602


https://reviews.llvm.org/D54551

Files:
  lib/CodeGen/RegisterCoalescer.cpp
  test/CodeGen/AMDGPU/regcoalesce-cannot-join-failures.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D54551.174114.patch
Type: text/x-patch
Size: 4341 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181114/dd56c4b2/attachment.bin>


More information about the llvm-commits mailing list